linux-kernel - Re: [PATCH] staging/usbip: fix store_attach() sscanf return value check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5331B0F9.9000403@cogentembedded.com>
Date:	Tue, 25 Mar 2014 19:38:17 +0300
From:	Sergei Shtylyov <sergei.shtylyov@...entembedded.com>
To:	Shuah Khan <shuah.kh@...sung.com>, gregkh@...uxfoundation.org,
	john@...ev.com, ced@...ck.net
CC:	linux-usb@...r.kernel.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, shuahkhan@...il.com
Subject: Re: [PATCH] staging/usbip: fix store_attach() sscanf return value
 check

Hello.

On 03/25/2014 02:12 AM, Shuah Khan wrote:

> Fix commit - 88fa1ebfa21b5deaaad2dc88ecd9f6af91796cf7

    Please also specify that commit's summary line in parens. Also, there's 
now an established format for such things:

Fixes: <12-digit SHA ID> ("<summary line>")

    You can place such line before your signoff line.

> This commit added return value check for sscanf() that parses the
> input buffer for four input items. However, the return value check
> is incorrect, as it checks for one input item instead of four which
> is what it is expecting in the input buffer. As a result, sscanf()
> will always fail even when the input buffer is correct.

> Signed-off-by: Shuah Khan <shuah.kh@...sung.com>

WBR, Sergei

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/