linux-kernel - Re: [PATCH v9 2/5] kernel: missing include in cputime.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1403251642310.20389@kaball.uk.xensource.com>
Date:	Tue, 25 Mar 2014 16:51:15 +0000
From:	Stefano Stabellini <stefano.stabellini@...citrix.com>
To:	Stefano Stabellini <stefano.stabellini@...citrix.com>
CC:	<peterz@...radead.org>, <linux-kernel@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>, <konrad.wilk@...cle.com>,
	<marc.zyngier@....com>, <will.deacon@....com>,
	Ian Campbell <Ian.Campbell@...rix.com>,
	<linux@....linux.org.uk>, <olof@...om.net>, <arnd@...db.de>,
	<catalin.marinas@....com>, <mingo@...hat.com>,
	<xen-devel@...ts.xensource.com>
Subject: Re: [PATCH v9 2/5] kernel: missing include in cputime.c

Peter,
I am sorry for the confusion, I have already asked you this question and
you have already kindly given me feedback on it. I have even addressed
the problem and resent.

However I wrongly tagged my emails and patch series.
The right patch are v7 and v8, without #ifdef CONFIG_PARAVIRT in
cputime.c:

http://marc.info/?l=linux-kernel&m=138920709703581&w=2

also appended below. I am very sorry for the confusion.
Would that be OK for you?

diff --git a/kernel/sched/cputime.c b/kernel/sched/cputime.c
index 9994791..9f9b76a 100644
--- a/kernel/sched/cputime.c
+++ b/kernel/sched/cputime.c
@@ -5,6 +5,7 @@
 #include <linux/static_key.h>
 #include <linux/context_tracking.h>
 #include "sched.h"
+#include <asm/paravirt.h>
 
 
 #ifdef CONFIG_IRQ_TIME_ACCOUNTING

On Tue, 25 Mar 2014, Stefano Stabellini wrote:
> Peter,
> is this patch OK for you?
> 
> On Thu, 9 Jan 2014, Stefano Stabellini wrote:
> > steal_account_process_tick calls paravirt_steal_clock, but paravirt.h is
> > currently missing among the included header files.
> > Add include asm/paravirt.h.
> > 
> > Signed-off-by: Stefano Stabellini <stefano.stabellini@...citrix.com>
> > CC: mingo@...hat.com
> > CC: peterz@...radead.org
> > ---
> >  kernel/sched/cputime.c |    3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/kernel/sched/cputime.c b/kernel/sched/cputime.c
> > index 9994791..951833e 100644
> > --- a/kernel/sched/cputime.c
> > +++ b/kernel/sched/cputime.c
> > @@ -5,6 +5,9 @@
> >  #include <linux/static_key.h>
> >  #include <linux/context_tracking.h>
> >  #include "sched.h"
> > +#ifdef CONFIG_PARAVIRT
> > +#include <asm/paravirt.h>
> > +#endif
> >  
> >  
> >  #ifdef CONFIG_IRQ_TIME_ACCOUNTING
> > -- 
> > 1.7.10.4
> > 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/