| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <CACRpkdY3ctcLNhpSWtuqj=d48_fqDyNzG9nGAorpAbwjAnOJUw@mail.gmail.com> Date: Tue, 25 Mar 2014 21:37:24 +0100 From: Linus Walleij <linus.walleij@...aro.org> To: Sebastian Andrzej Siewior <bigeasy@...utronix.de> Cc: Alan Tull <atull@...era.com>, Alexandre Courbot <gnurou@...il.com>, "linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Dinh Nguyen <dinguyen@...era.com> Subject: Re: [PATCH 1/3] gpio: dwapb: drop irq_setup_generic_chip() On Thu, Mar 20, 2014 at 8:55 PM, Sebastian Andrzej Siewior <bigeasy@...utronix.de> wrote: > This looks kinda wrong I didn't manage to fully test it. > The driver calls irq_alloc_domain_generic_chips() which creates a gc and > adds it to gc_list. The driver later then calls irq_setup_generic_chip() > which also initializes the gc and adds it to the gc_list() and this > corrupts the list. > I can't find a single chip in tree which uses both functions so I think > that irq_setup_generic_chip() can be dropped. > > Signed-off-by: Sebastian Andrzej Siewior <bigeasy@...utronix.de> Jamie: comments? Can you instead of this try to use my new generic gpiolib irqchip helpers that I just merged to the GPIO tree? Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists