linux-kernel - Re: [PATCH] ata: fix Marvell SATA driver dependencies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <4852939.9jMb8Bv2x2@amdc1032>
Date:	Wed, 26 Mar 2014 18:12:31 +0100
From:	Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>
To:	One Thousand Gnomes <gnomes@...rguk.ukuu.org.uk>
Cc:	Andrew Lunn <andrew@...n.ch>, Tejun Heo <tj@...nel.org>,
	Jason Cooper <jason@...edaemon.net>,
	Gregory Clement <gregory.clement@...e-electrons.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
	linux-ide@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ata: fix Marvell SATA driver dependencies


Hi,

On Wednesday, March 26, 2014 04:59:04 PM One Thousand Gnomes wrote:
> On Wed, 26 Mar 2014 17:23:02 +0100
> Andrew Lunn <andrew@...n.ch> wrote:
> 
> > On Wed, Mar 26, 2014 at 05:19:02PM +0100, Bartlomiej Zolnierkiewicz wrote:
> > > Make sata_mv host driver depend on PCI || ARCH_KIRKWOOD || ARCH_MVEBU ||
> > > ARCH_ORION5X config options as Marvell SATA support covers both Marvell
> > > PCI devices and Marvell Kirkwood, Armada 370/XP and Orion5x SoCs (for
> > > non-PCI devices the driver to work requires suitable device tree node to
> > > be defined).  Additionally allow the driver build if COMPILE_TEST config
> > > option is set.
> > 
> > Hi Bartlomiej
> > 
> > I _think_ there are a few powerpc platforms which can also make use of
> > this driver
> 
> The hardware can show up in just about anything so I think this patch
> should be dropped

In theory maybe but in practice it for sure won't show up if the vendor
has its own SATA solution and at least in the ARM world it seems frequent
to have its own AHCI variant nowadays.  Moreover even if the new usage
shows up it is not enough to enable driver for it to make it work as
you also need to add a node describing your SATA MV variant to your SoC
device tree file (which requires updating kernel source anyway).

Best regards,
--
Bartlomiej Zolnierkiewicz
Samsung R&D Institute Poland
Samsung Electronics

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/