lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 26 Mar 2014 09:29:37 +0800 From: micky <micky_ching@...lsil.com.cn> To: Ulf Hansson <ulf.hansson@...aro.org> CC: Chris Ball <chris@...ntf.net>, Samuel Ortiz <sameo@...ux.intel.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Dan Carpenter <dan.carpenter@...cle.com>, <devel@...uxdriverproject.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, linux-mmc <linux-mmc@...r.kernel.org>, Roger <rogerable@...ltek.com>, Wei WANG <wei_wang@...lsil.com.cn> Subject: Re: [PATCH 0/2] mmc: rtsx: add new cmd type handle and modify errorhandle Hi Ulf, On 03/25/2014 06:44 PM, Ulf Hansson wrote: > On 25 March 2014 10:47, <micky_ching@...lsil.com.cn> wrote: >> From: Micky Ching <micky_ching@...lsil.com.cn> >> >> Add new command type(R1 without CRC) handle, without this >> patch mmc card initialize will be failed. >> >> Using a more careful handle in request timeout, this would >> improve error recover capability. Debug info is printed >> using non DMA mode, this would help print more accurately >> for DMA command failed. Smatch warning was removed. > Hi Micky, > > Seems like this patchset has been around for some time, sorry for the delay. > > I don't have any objections to it getting merged, but you need to run > checkpatch of your patches. Patch2 has a warning you should fix. Patch2 is based on <mmc: rtsx: fix bug and support nonblocking request> see: https://lkml.org/lkml/2014/2/17/270 checkpatch.pl seems ok, is there any thing I need to check? Best Regards. micky. > Kind regards > Ulf Hansson > > >> Micky Ching (2): >> mmc: rtsx: add R1-no-CRC mmc command type handle >> mmc: rtsx: modify error handle and remove smatch warnings >> >> drivers/mmc/host/rtsx_pci_sdmmc.c | 121 ++++++++++++++++++++----------------- >> 1 file changed, 67 insertions(+), 54 deletions(-) >> >> -- >> 1.7.9.5 > . > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists