linux-kernel - [PATCH] perf: make perf script actually spit out backtraces for events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <1395860245-12418-1-git-send-email-jbacik@fb.com>
Date:	Wed, 26 Mar 2014 14:57:25 -0400
From:	Josef Bacik <jbacik@...com>
To:	<linux-kernel@...r.kernel.org>, <a.p.zijlstra@...llo.nl>,
	<mingo@...hat.com>, <acme@...stprotocols.net>
Subject: [PATCH] perf: make perf script actually spit out backtraces for events

We are trying to debug a problem internally and noticed that if we use perf
record -g -e <tracepoint> and then try to use perf script to get the events and
their backtraces that we weren't getting the backtraces, even though they were
collected and would show up with perf report.  For some reason the tracepoint
print stuff didn't have the right things set in order to print out backtraces.
I have no idea why this is as adding them in there makes the backtraces come out
properly, and if we don't use the -g option perf script still acts properly with
those options set.  Hopefully this is the correct fix, it has fixed the problem
for us.  Thanks,

Signed-off-by: Josef Bacik <jbacik@...com>
---
NOTE: I looked at MAINTAINERS to see if there was a perf list and it didn't look
like there was one, sorry if this is the wrong place to send patches to.

 tools/perf/builtin-script.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/tools/perf/builtin-script.c b/tools/perf/builtin-script.c
index baf1798..6d14c06 100644
--- a/tools/perf/builtin-script.c
+++ b/tools/perf/builtin-script.c
@@ -99,7 +99,9 @@ static struct {

 		.fields = PERF_OUTPUT_COMM | PERF_OUTPUT_TID |
 				  PERF_OUTPUT_CPU | PERF_OUTPUT_TIME |
-				  PERF_OUTPUT_EVNAME | PERF_OUTPUT_TRACE,
+				  PERF_OUTPUT_EVNAME | PERF_OUTPUT_TRACE |
+				  PERF_OUTPUT_IP | PERF_OUTPUT_SYM |
+				  PERF_OUTPUT_DSO,
 	},

 	[PERF_TYPE_RAW] = {
-- 
1.8.3.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/