linux-kernel - Re: [PATCH 2/7] atm: replace del_timer by del_timer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1395871015.12610.254.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Wed, 26 Mar 2014 14:56:55 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Julia Lawall <Julia.Lawall@...6.fr>
Cc:	"David S. Miller" <davem@...emloft.net>,
	kernel-janitors@...r.kernel.org, tglx@...utronix.de,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/7] atm: replace del_timer by del_timer_sync

On Wed, 2014-03-26 at 22:33 +0100, Julia Lawall wrote:
> From: Julia Lawall <Julia.Lawall@...6.fr>

> 
> diff --git a/net/atm/mpc.c b/net/atm/mpc.c
> index b71ff6b..91dc58f 100644
> --- a/net/atm/mpc.c
> +++ b/net/atm/mpc.c
> @@ -1492,7 +1492,7 @@ static void __exit atm_mpoa_cleanup(void)
>  
>  	mpc_proc_clean();
>  
> -	del_timer(&mpc_timer);
> +	del_timer_sync(&mpc_timer);
>  	unregister_netdevice_notifier(&mpoa_notifier);
>  	deregister_atm_ioctl(&atm_ioctl_ops);
>  

It seems this timer rearms itself, so this patch wont be enough I fear.




--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/