linux-kernel - Re: [PATCH] regmap: Add REGMAP_ENDIAN

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140327114039.GJ30768@sirena.org.uk>
Date:	Thu, 27 Mar 2014 11:40:39 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Xiubo Li <Li.Xiubo@...escale.com>
Cc:	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] regmap: Add REGMAP_ENDIAN_SWAP support for values.

On Thu, Mar 27, 2014 at 04:17:39PM +0800, Xiubo Li wrote:

> For the DT node, just one property like 'endian-swap' will be okey
> for cases 2 and 4.

I'm not convinced that the cost of having to define explicit big and
little endian properties for the hardware is worth having this - it
seems like a confusing thing to have in the interface since it depends
on both the device and the CPU and would presumably break in cases where
there's an option about which endianness to run things in.

> And using the REGMAP_ENDIAN_BIG and REGMAP_ENDIAN_LITTLE will make
> the driver a bit more complex, and also the usage of it.

What's the complexity here?

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)