linux-kernel - Re: [PATCH] i2c: omap: fix usage of IS_ERR_VALUE with pm_runtime_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140327175231.GC11379@katana>
Date:	Thu, 27 Mar 2014 18:52:31 +0100
From:	Wolfram Sang <wsa@...-dreams.de>
To:	Nishanth Menon <nm@...com>
Cc:	Tony Lindgren <tony@...mide.com>, linux-omap@...r.kernel.org,
	linux-i2c@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] i2c: omap: fix usage of IS_ERR_VALUE with
 pm_runtime_get_sync

On Thu, Mar 27, 2014 at 11:18:33AM -0500, Nishanth Menon wrote:
> we use IS_ERR_VALUE to check for error values of pm_runtime_get_sync,
> when the value can only be < 0 in the case of err. Replace the
> check with a simpler < 0 check.
> 
> This fixes the coccicheck warnings:
> linux-2.6/drivers/i2c/busses/i2c-omap.c:1157:5-24:
> pm_runtime_get_sync returns < 0 as error. Unecessary IS_ERR_VALUE at
> line 1158
> linux-2.6/drivers/i2c/busses/i2c-omap.c:1278:7-26:
> pm_runtime_get_sync returns < 0 as error. Unecessary IS_ERR_VALUE at
> line 1279
> drivers/i2c/busses/i2c-omap.c:638:5-24:
> pm_runtime_get_sync returns < 0 as error. Unecessary IS_ERR_VALUE at
> line 639
> 
> Signed-off-by: Nishanth Menon <nm@...com>

Applied to for-next, thanks!


Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)