linux-kernel - Re: [media] videobuf-dma-contig: fix vm_iomap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <533540CE.8070703@xs4all.nl>
Date:	Fri, 28 Mar 2014 10:28:46 +0100
From:	Hans Verkuil <hverkuil@...all.nl>
To:	Ma Haijun <mahaijuns@...il.com>, linux-media@...r.kernel.org,
	linux-kernel@...r.kernel.org
CC:	Mauro Carvalho Chehab <m.chehab@...sung.com>,
	Al Viro <viro@...IV.linux.org.uk>
Subject: Re: [media] videobuf-dma-contig: fix vm_iomap_memory() call

On 03/27/2014 12:07 PM, Ma Haijun wrote:
> Hi all,
> 
> This is a trivial fix, but I think the patch itself has problem too. 
> The function requires a phys_addr_t, but we feed it with a dma_handle_t.
> AFAIK, this implicit conversion does not always work.
> Can I use virt_to_phys(mem->vaddr) to get the physical address instead?
> (mem->vaddr and mem->dma_handle are from dma_alloc_coherent)

Does this actually fail? With what driver and on what hardware?

I ask because I am very reluctant to make any changes to videobuf. It is
slowly being replaced by the vastly superior videobuf2 framework. Existing
drivers in the kernel still using the old videobuf seem to work just fine
(or at least as fine as videobuf allows you to be).

Regards,

	Hans

> 
> Regards
> 
> Ma Haijun
> 
> Ma Haijun (1):
>   [media] videobuf-dma-contig: fix incorrect argument to
>     vm_iomap_memory() call
> 
>  drivers/media/v4l2-core/videobuf-dma-contig.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/