linux-kernel - Re: [PATCH] ASoC: fsl_sai: Improve fsl_sai

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140328123054.GG30768@sirena.org.uk>
Date:	Fri, 28 Mar 2014 12:30:54 +0000
From:	Mark Brown <broonie@...nel.org>
To:	Nicolin Chen <Guangyu.Chen@...escale.com>
Cc:	Li.Xiubo@...escale.com, linux-kernel@...r.kernel.org,
	linuxppc-dev@...ts.ozlabs.org, alsa-devel@...a-project.org,
	timur@...i.org
Subject: Re: [PATCH] ASoC: fsl_sai: Improve fsl_sai_isr()

On Fri, Mar 28, 2014 at 07:39:25PM +0800, Nicolin Chen wrote:
> This patch improves fsl_sai_isr() in these ways:
> 1, Add comment for mask fetching code.
> 2, Return IRQ_NONE if the IRQ is not for the device.
> 3, Use regmap_write() instead of regmap_update_bits().

Applied, thanks.  It would have been better to do separate patches here
- actually with your explanation the update_bits() made sense so you
could've left that but equally it doesn't do any harm to skip the read.

Download attachment "signature.asc" of type "application/pgp-signature" (837 bytes)