linux-kernel - Re: [PATCH] extcon: palmas: explicitly set edev name as node name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140328144936.GF17820@saruman.home>
Date:	Fri, 28 Mar 2014 09:49:36 -0500
From:	Felipe Balbi <balbi@...com>
To:	Kishon Vijay Abraham I <kishon@...com>
CC:	<myungjoo.ham@...sung.com>, <cw00.choi@...sung.com>,
	<linux-kernel@...r.kernel.org>, <gregkh@...uxfoundation.org>,
	<balbi@...com>
Subject: Re: [PATCH] extcon: palmas: explicitly set edev name as node name

On Fri, Mar 28, 2014 at 12:21:02PM +0530, Kishon Vijay Abraham I wrote:
> commit ca488 (extcon: of: Remove unnecessary function call by using the
> name of device_node) started using node name instead of device name
> to get the extcon device. This breaks dwc3-omap since it's not able to
> get the extcon device anymore. Fixed it by setting edev name of
> palmas to be the same as its node name.
> 
> Signed-off-by: Kishon Vijay Abraham I <kishon@...com>
> Reported-by: Felipe Balbi <balbi@...com>

Thanks Kishon, I tested something similar yesterday and I saw that it
helped a lot. I'm still missing something (maybe DTS) because dwc3 still
didn't probe even after fixing this.

Reviewed-by: Felipe Balbi <balbi@...com>

> ---
>  drivers/extcon/extcon-palmas.c |    5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/drivers/extcon/extcon-palmas.c b/drivers/extcon/extcon-palmas.c
> index 2aea4bc..51dee21 100644
> --- a/drivers/extcon/extcon-palmas.c
> +++ b/drivers/extcon/extcon-palmas.c
> @@ -23,6 +23,7 @@
>  #include <linux/module.h>
>  #include <linux/interrupt.h>
>  #include <linux/platform_device.h>
> +#include <linux/slab.h>
>  #include <linux/err.h>
>  #include <linux/mfd/palmas.h>
>  #include <linux/of.h>
> @@ -188,11 +189,13 @@ static int palmas_usb_probe(struct platform_device *pdev)
>  
>  	palmas_usb->edev.supported_cable = palmas_extcon_cable;
>  	palmas_usb->edev.dev.parent = palmas_usb->dev;
> +	palmas_usb->edev.name = kstrdup(node->name, GFP_KERNEL);
>  	palmas_usb->edev.mutually_exclusive = mutually_exclusive;
>  
>  	status = extcon_dev_register(&palmas_usb->edev);
>  	if (status) {
>  		dev_err(&pdev->dev, "failed to register extcon device\n");
> +		kfree(palmas_usb->edev.name);
>  		return status;
>  	}
>  
> @@ -230,6 +233,7 @@ static int palmas_usb_probe(struct platform_device *pdev)
>  
>  fail_extcon:
>  	extcon_dev_unregister(&palmas_usb->edev);
> +	kfree(palmas_usb->edev.name);
>  
>  	return status;
>  }
> @@ -239,6 +243,7 @@ static int palmas_usb_remove(struct platform_device *pdev)
>  	struct palmas_usb *palmas_usb = platform_get_drvdata(pdev);
>  
>  	extcon_dev_unregister(&palmas_usb->edev);
> +	kfree(palmas_usb->edev.name);
>  
>  	return 0;
>  }
> -- 
> 1.7.9.5
> 

-- 
balbi

Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)