linux-kernel - Re: [PATCH v1] net-sysfs: expose number of link up/down transitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1396028776.12610.341.camel@edumazet-glaptop2.roam.corp.google.com>
Date:	Fri, 28 Mar 2014 10:46:16 -0700
From:	Eric Dumazet <eric.dumazet@...il.com>
To:	Florian Fainelli <f.fainelli@...il.com>
Cc:	Jiri Pirko <jiri@...nulli.us>,
	David Decotigny <decot@...glers.com>,
	"David S. Miller" <davem@...emloft.net>,
	Jamal Hadi Salim <jhs@...atatu.com>,
	netdev <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Eric Dumazet <edumazet@...gle.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Weilong Chen <chenweilong@...wei.com>,
	Amir Vadai <amirv@...lanox.com>,
	Michael Dalton <mwdalton@...gle.com>,
	Al Viro <viro@...iv.linux.org.uk>, Tejun Heo <tj@...nel.org>
Subject: Re: [PATCH v1] net-sysfs: expose number of link up/down transitions

On Fri, 2014-03-28 at 09:51 -0700, Florian Fainelli wrote:
> 2014-03-27 23:25 GMT-07:00 Jiri Pirko <jiri@...nulli.us>:
> >
> > If this is exposed in sysfs, this needs to be exposed via RT netlink as
> > well.
> 
> This makes me wonder if this really needs to be a kernel-maintained
> pair of counters. Since this seems to be useful for monitoring e.g:
> servers for link flapping, I would assume that some user-space
> script/program does read these sysfs entries periodically to report a
> healthy link. If that's the case, what prevents the same
> script/program from listening to netlink events and count the link
> UP/DOWN events from there and report that?

The same would be true for any counter in networking stack...

I do not feel we need to have a daemon running to 'count' events.

I like being able to run "ip -s link" , "ifconfig -a" or "nstat -a"
without having to connect to a daemon. This daemon will likely have
different api / constraints from distro to distro.

To me, first thing is a counter, then eventually events for daemons.

drop_monitor could eventually disappear if we had counters everywhere we
need them.



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/