linux-kernel - Re: [PATCH 1/1] staging: fix bcm/hostmibs.c checkpatch problems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140328124901.6371fa1a@quetzal.lan>
Date:	Fri, 28 Mar 2014 12:49:01 -0600
From:	Jake Edge <jake@...e2.net>
To:	Joe Perches <joe@...ches.com>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jade Bilkey <herself@...fumon.com>, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] staging: fix bcm/hostmibs.c checkpatch problems

On Sun, 23 Mar 2014 10:45:09 -0700 Joe Perches wrote:
> On Sat, 2014-03-22 at 09:50 -0600, Jake Edge wrote:
> > Fix 4 checkpatch errors, many warnings in bcm/hostmibs.c
> 
> Making code checkpatch clean shouldn't be the primary goal here.

Perhaps not, but it was *my* goal :)

> Removing uses of Hungarian-style notation, CamelCase naming, and
> long variable names would be more helpful overall.

I don't have enough experience to feel comfortable about doing that
yet, but I did take some of your suggestions and am respinning the
patch ...

thanks,

jake 

-- 
Jake Edge - jake@...e2.net - http://www.edge2.net
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/