linux-kernel - Staging:et131x: change memcpy() ether_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 28 Mar 2014 22:27:22 +0000
From:	paulmcquad <paulmcquad@...il.com>
To:	gregkh@...uxfoundation.org, gamerh2o@...il.com,
	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Staging:et131x: change memcpy()  ether_addr_copy()

>From 63f3c8948d5264ab22695502b201ff50edb9028d Mon Sep 17 00:00:00 2001
From: Paul McQuade <paulmcquad@...il.com>
Date: Fri, 28 Mar 2014 22:16:22 +0000
Subject: [PATCH] Staging:et131x: change memcpy()  ether_addr_copy()

replace memcpy() with ether_addr_copy()
make checkpatch.pl clean

Signed-off-by: Paul McQuade <paulmcquad@...il.com>
---
 drivers/staging/et131x/et131x.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/staging/et131x/et131x.c b/drivers/staging/et131x/et131x.c
index e516bb6..a35d3c8 100644
--- a/drivers/staging/et131x/et131x.c
+++ b/drivers/staging/et131x/et131x.c
@@ -3523,7 +3523,7 @@ static int et131x_pci_init(struct et131x_adapter *adapter,
             goto err_out;
         }
     }
-    memcpy(adapter->addr, adapter->rom_addr, ETH_ALEN);
+    ether_addr_copy(adapter->addr, adapter->rom_addr, ETH_ALEN);
 out:
     return rc;
 err_out:
@@ -3770,7 +3770,7 @@ static struct et131x_adapter *et131x_adapter_init(struct net_device *netdev,
     adapter->registry_jumbo_packet = 1514;    /* 1514-9216 */
 
     /* Set the MAC address to a default */
-    memcpy(adapter->addr, default_mac, ETH_ALEN);
+    ether_addr_copy(adapter->addr, default_mac, ETH_ALEN);
 
     return adapter;
 }
@@ -4337,7 +4337,7 @@ static void et131x_multicast(struct net_device *netdev)
     netdev_for_each_mc_addr(ha, netdev) {
         if (i == NIC_MAX_MCAST_LIST)
             break;
-        memcpy(adapter->multicast_list[i++], ha->addr, ETH_ALEN);
+    ether_addr_copy(adapter->multicast_list[i++], ha->addr, ETH_ALEN);
     }
     adapter->multicast_addr_count = i;
 
@@ -4473,7 +4473,7 @@ static int et131x_change_mtu(struct net_device *netdev, int new_mtu)
     et131x_init_send(adapter);
 
     et131x_hwaddr_init(adapter);
-    memcpy(netdev->dev_addr, adapter->addr, ETH_ALEN);
+    ether_addr_copy(netdev->dev_addr, adapter->addr, ETH_ALEN);
 
     /* Init the device with the new settings */
     et131x_adapter_setup(adapter);
@@ -4644,7 +4644,7 @@ static int et131x_pci_setup(struct pci_dev *pdev,
     INIT_WORK(&adapter->task, et131x_isr_handler);
 
     /* Copy address into the net_device struct */
-    memcpy(netdev->dev_addr, adapter->addr, ETH_ALEN);
+    ether_addr_copy(netdev->dev_addr, adapter->addr, ETH_ALEN);
 
     /* Init variable for counting how long we do not have link status */
     adapter->boot_coma = 0;
-- 
1.8.3.2

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/