lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Sat, 29 Mar 2014 23:50:37 +0530
From:	Rashika Kheria <rashika.kheria@...il.com>
To:	linux-kernel@...r.kernel.org
Cc:	"James E.J. Bottomley" <JBottomley@...allels.com>,
	Rashika Kheria <rashika.kheria@...il.com>,
	linux-scsi@...r.kernel.org, josh@...htriplett.org
Subject: [PATCH 32/55] scsi: Mark functions as static in mvsas/mv_64xx.c

Mark functions as static in mvsas/mv_64xx.c because they are not used
outside this file.

This eliminates the following warnings in mvsas/mv_64xx.c:
drivers/scsi/mvsas/mv_64xx.c:139:6: warning: no previous prototype for ‘mvs_64xx_clear_srs_irq’ [-Wmissing-prototypes]
drivers/scsi/mvsas/mv_64xx.c:566:6: warning: no previous prototype for ‘mvs_64xx_make_prd’ [-Wmissing-prototypes]
drivers/scsi/mvsas/mv_64xx.c:636:6: warning: no previous prototype for ‘mvs_64xx_phy_set_link_rate’ [-Wmissing-prototypes]
drivers/scsi/mvsas/mv_64xx.c:671:5: warning: no previous prototype for ‘mvs_64xx_spi_read_data’ [-Wmissing-prototypes]
drivers/scsi/mvsas/mv_64xx.c:677:6: warning: no previous prototype for ‘mvs_64xx_spi_write_data’ [-Wmissing-prototypes]
drivers/scsi/mvsas/mv_64xx.c:684:5: warning: no previous prototype for ‘mvs_64xx_spi_buildcmd’ [-Wmissing-prototypes]
drivers/scsi/mvsas/mv_64xx.c:708:5: warning: no previous prototype for ‘mvs_64xx_spi_issuecmd’ [-Wmissing-prototypes]
drivers/scsi/mvsas/mv_64xx.c:723:5: warning: no previous prototype for ‘mvs_64xx_spi_waitdataready’ [-Wmissing-prototypes]
drivers/scsi/mvsas/mv_64xx.c:738:6: warning: no previous prototype for ‘mvs_64xx_fix_dma’ [-Wmissing-prototypes]

Signed-off-by: Rashika Kheria <rashika.kheria@...il.com>
Reviewed-by: Josh Triplett <josh@...htriplett.org>
---
 drivers/scsi/mvsas/mv_64xx.c |   35 ++++++++++++++++++-----------------
 1 file changed, 18 insertions(+), 17 deletions(-)

diff --git a/drivers/scsi/mvsas/mv_64xx.c b/drivers/scsi/mvsas/mv_64xx.c
index 8bb0699..2420386 100644
--- a/drivers/scsi/mvsas/mv_64xx.c
+++ b/drivers/scsi/mvsas/mv_64xx.c
@@ -136,7 +136,8 @@ static void mvs_64xx_phy_reset(struct mvs_info *mvi, u32 phy_id, int hard)
 	}
 }
 
-void mvs_64xx_clear_srs_irq(struct mvs_info *mvi, u8 reg_set, u8 clear_all)
+static void mvs_64xx_clear_srs_irq(struct mvs_info *mvi, u8 reg_set,
+				   u8 clear_all)
 {
 	void __iomem *regs = mvi->regs;
 	u32 tmp;
@@ -563,7 +564,7 @@ static u8 mvs_64xx_assign_reg_set(struct mvs_info *mvi, u8 *tfs)
 	return MVS_ID_NOT_MAPPED;
 }
 
-void mvs_64xx_make_prd(struct scatterlist *scatter, int nr, void *prd)
+static void mvs_64xx_make_prd(struct scatterlist *scatter, int nr, void *prd)
 {
 	int i;
 	struct scatterlist *sg;
@@ -633,8 +634,8 @@ static void mvs_64xx_phy_work_around(struct mvs_info *mvi, int i)
 	mvs_write_port_vsr_data(mvi, i, tmp);
 }
 
-void mvs_64xx_phy_set_link_rate(struct mvs_info *mvi, u32 phy_id,
-			struct sas_phy_linkrates *rates)
+static void mvs_64xx_phy_set_link_rate(struct mvs_info *mvi, u32 phy_id,
+				struct sas_phy_linkrates *rates)
 {
 	u32 lrmin = 0, lrmax = 0;
 	u32 tmp;
@@ -668,26 +669,26 @@ static void mvs_64xx_clear_active_cmds(struct mvs_info *mvi)
 }
 
 
-u32 mvs_64xx_spi_read_data(struct mvs_info *mvi)
+static u32 mvs_64xx_spi_read_data(struct mvs_info *mvi)
 {
 	void __iomem *regs = mvi->regs_ex;
 	return ior32(SPI_DATA_REG_64XX);
 }
 
-void mvs_64xx_spi_write_data(struct mvs_info *mvi, u32 data)
+static void mvs_64xx_spi_write_data(struct mvs_info *mvi, u32 data)
 {
 	void __iomem *regs = mvi->regs_ex;
 	 iow32(SPI_DATA_REG_64XX, data);
 }
 
 
-int mvs_64xx_spi_buildcmd(struct mvs_info *mvi,
-			u32      *dwCmd,
-			u8       cmd,
-			u8       read,
-			u8       length,
-			u32      addr
-			)
+static int mvs_64xx_spi_buildcmd(struct mvs_info *mvi,
+				u32      *dwCmd,
+				u8       cmd,
+				u8       read,
+				u8       length,
+				u32      addr
+				)
 {
 	u32  dwTmp;
 
@@ -705,7 +706,7 @@ int mvs_64xx_spi_buildcmd(struct mvs_info *mvi,
 }
 
 
-int mvs_64xx_spi_issuecmd(struct mvs_info *mvi, u32 cmd)
+static int mvs_64xx_spi_issuecmd(struct mvs_info *mvi, u32 cmd)
 {
 	void __iomem *regs = mvi->regs_ex;
 	int     retry;
@@ -720,7 +721,7 @@ int mvs_64xx_spi_issuecmd(struct mvs_info *mvi, u32 cmd)
 	return 0;
 }
 
-int mvs_64xx_spi_waitdataready(struct mvs_info *mvi, u32 timeout)
+static int mvs_64xx_spi_waitdataready(struct mvs_info *mvi, u32 timeout)
 {
 	void __iomem *regs = mvi->regs_ex;
 	u32 i, dwTmp;
@@ -735,8 +736,8 @@ int mvs_64xx_spi_waitdataready(struct mvs_info *mvi, u32 timeout)
 	return -1;
 }
 
-void mvs_64xx_fix_dma(struct mvs_info *mvi, u32 phy_mask,
-				int buf_len, int from, void *prd)
+static void mvs_64xx_fix_dma(struct mvs_info *mvi, u32 phy_mask,
+			     int buf_len, int from, void *prd)
 {
 	int i;
 	struct mvs_prd *buf_prd = prd;
-- 
1.7.9.5

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists