linux-kernel - Re: [PATCH V2] scripts: objdiff: detect object code changes between two commits

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 29 Mar 2014 22:31:28 +0100
From:	Michal Marek <mmarek@...e.cz>
To:	Jason Cooper <jason@...edaemon.net>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Joe Perches <joe@...ches.com>,
	"Yann E . MORIN" <yann.morin.1998@...e.fr>,
	Rusty Russell <rusty@...tcorp.com.au>
CC:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH V2] scripts: objdiff: detect object code changes between
 two commits

Dne 24.3.2014 03:14, Jason Cooper napsal(a):
> 
> objdiff can be used in conjunction with a git rebase to confirm that
> each commit made no changes to the resulting object code.  It has the
> same return values as diff(1).

This looks nice. Just a few comments below:


> +# usage example:
> +#
> +# $ git checkout COMMIT_A
> +# $ <your fancy build command here>
> +# $ ./scripts/objdiff record path/to/*.o
> +#
> +# $ git checkout COMMIT_B
> +# $ <your fancy build command here>
> +# $ ./scripts/objdiff record path/to/*.o
> +#
> +# $ ./scripts/objdiff diff COMMIT_A COMMIT_B
> +# $
> +
> +# And to clean up (everything is in /tmp/objdiff-*)
> +# $ ./scripts/objdiff clean all

Can you change it to use some path in the source tree, like .tmp_objdiff
or so? Then you can have make distclean remove it and you can avoid the
fixed paths in /tmp.


> +		# force rebuild
> +		rm -f "$f"

Is this working around some kbuild bug, or is it more a "just in case?"
One usually assumes that "record" is a readonly operation and can be
repeated.

Thanks,
Michal
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/