linux-kernel - Re: [PATCH 1/1] Drivers: hid: hid-hyperv: Implement a stub raw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1403281842100.16202@pobox.suse.cz>
Date:	Fri, 28 Mar 2014 18:42:44 -0700 (PDT)
From:	Jiri Kosina <jkosina@...e.cz>
To:	"K. Y. Srinivasan" <kys@...rosoft.com>
cc:	gregkh@...e.de, linux-kernel@...r.kernel.org,
	devel@...uxdriverproject.org, ohering@...e.com,
	benjamin.tissoires@...hat.com, dh.herrmann@...il.com
Subject: Re: [PATCH 1/1] Drivers: hid: hid-hyperv: Implement a stub 
 raw_request() entry point

On Fri, 28 Mar 2014, K. Y. Srinivasan wrote:

> commit 3c86726cfe38952f0366f86acfbbb025813ec1c2
> Author: Benjamin Tissoires <benjamin.tissoires@...hat.com>
> Date:   Thu Feb 20 15:24:49 2014 -0500
> 
>     HID: make .raw_request mandatory
> 
>     SET_REPORT and GET_REPORT are mandatory in the HID specification.
>     Make the corresponding API in hid-core mandatory too, which removes the
>     need to test against it in some various places.
> 
>     Signed-off-by: Benjamin Tissoires <benjamin.tissoires@...hat.com>
>     Reviewed-by: David Herrmann <dh.herrmann@...il.com>
>     Signed-off-by: Jiri Kosina <jkosina@...e.cz>
> 
> Made .raw_request mandatory and broke the Hyper-V mouse driver. This patch
> fixes the problem.
> 
> Signed-off-by: K. Y. Srinivasan <kys@...rosoft.com>
> ---
>  drivers/hid/hid-hyperv.c |   10 ++++++++++
>  1 files changed, 10 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/hid/hid-hyperv.c b/drivers/hid/hid-hyperv.c
> index c24908f..89a9234 100644
> --- a/drivers/hid/hid-hyperv.c
> +++ b/drivers/hid/hid-hyperv.c
> @@ -460,12 +460,22 @@ static void mousevsc_hid_stop(struct hid_device *hid)
>  {
>  }
>  
> +static int mousevsc_hid_raw_request(struct hid_device *hid,
> +				    unsigned char report_num,
> +				    __u8 buf, size_t len,

This should be __u8 *buf. I have fixed that and applied.

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/