[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <87vbuv9vaz.fsf@river.i-did-not-set--mail-host-address--so-tickle-me>
Date: Mon, 31 Mar 2014 09:27:16 +1100
From: Stewart Smith <stewart@...ux.vnet.ibm.com>
To: Greg Kurz <gkurz@...ux.vnet.ibm.com>, benh@...nel.crashing.org
Cc: linux-kernel@...r.kernel.org, paulus@...ba.org, anton@...ba.org,
nfont@...ux.vnet.ibm.com, linuxppc-dev@...ts.ozlabs.org
Subject: Re: [PATCH] powerpc/le: enable RTAS events support
Greg Kurz <gkurz@...ux.vnet.ibm.com> writes:
> struct rtas_error_log {
> +#ifdef __BIG_ENDIAN__
> + /* Byte 0 */
> unsigned long version:8; /* Architectural version */
> + /* Byte 1 */
I think it would be great if we got rid of the usage of bitfields. As
soon as the mood of the compiler changes, this code is going to break.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists