linux-kernel - Re: [PATCH] x86: Fix the symbol versions on the 32-bit vDSO

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1396206040.9781.1.camel@vger.seibold.net>
Date:	Sun, 30 Mar 2014 21:00:40 +0200
From:	Stefani Seibold <stefani@...bold.net>
To:	"H. Peter Anvin" <hpa@...or.com>
Cc:	Andy Lutomirski <luto@...capital.net>, X86 ML <x86@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] x86: Fix the symbol versions on the 32-bit vDSO

I think it is in review. I still wait for the confirmation of my assign
form.

Am Sonntag, den 30.03.2014, 09:59 -0700 schrieb H. Peter Anvin:
> Has your glibc patch been accepted upstream yet? I'm assuming not, in which case this is a legitimate patch.
> 
> On March 29, 2014 11:33:37 PM PDT, Stefani Seibold <stefani@...bold.net> wrote:
> >Am Samstag, den 29.03.2014, 13:15 -0700 schrieb Andy Lutomirski:
> >> The new symbols provide the same API as the 64-bit variants, so they
> >> should have the same symbol version name.  This can't break
> >> userspace, since these symbols are new for 32-bit Linux.
> >> 
> >
> >This breaks my glibc patch... What is the benefit for doing this in
> >that
> >way?
> >
> >> Signed-off-by: Andy Lutomirski <luto@...capital.net>
> >> ---
> >>  arch/x86/vdso/vdso32/vdso32.lds.S | 10 +++++++---
> >>  1 file changed, 7 insertions(+), 3 deletions(-)
> >> 
> >> diff --git a/arch/x86/vdso/vdso32/vdso32.lds.S
> >b/arch/x86/vdso/vdso32/vdso32.lds.S
> >> index 28c4607..aadb8b9 100644
> >> --- a/arch/x86/vdso/vdso32/vdso32.lds.S
> >> +++ b/arch/x86/vdso/vdso32/vdso32.lds.S
> >> @@ -23,14 +23,18 @@ ENTRY(__kernel_vsyscall);
> >>   */
> >>  VERSION
> >>  {
> >> +	LINUX_2.6 {
> >> +	global:
> >> +		__vdso_clock_gettime;
> >> +		__vdso_gettimeofday;
> >> +		__vdso_time;
> >> +	};
> >> +
> >>  	LINUX_2.5 {
> >>  	global:
> >>  		__kernel_vsyscall;
> >>  		__kernel_sigreturn;
> >>  		__kernel_rt_sigreturn;
> >> -		__vdso_clock_gettime;
> >> -		__vdso_gettimeofday;
> >> -		__vdso_time;
> >>  	local: *;
> >>  	};
> >>  }
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/