linux-kernel - Re: [PATCH] staging: serqt_usb2: Add blank lines after declarations.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Sun, 30 Mar 2014 19:02:41 -0700
From:	Joe Perches <joe@...ches.com>
To:	Thomas Vegas <thomas_75@...e-mail.net>
Cc:	gregkh@...uxfoundation.org, linux-kernel@...r.kernel.org,
	devel@...verdev.osuosl.org
Subject: Re: [PATCH] staging: serqt_usb2: Add blank lines after declarations.

On Sun, 2014-03-30 at 23:29 +0200, Thomas Vegas wrote:
> Use a more common kernel coding style.
[]
> diff --git a/drivers/staging/serqt_usb2/serqt_usb2.c b/drivers/staging/serqt_usb2/serqt_usb2.c
[]
> @@ -995,8 +995,8 @@ static void qt_close(struct usb_serial_port *port)
>  	struct tty_struct *tty;
>  	int status;
>  	unsigned int index;
> -	status = 0;
>  
> +	status = 0;

My preference would be to change the declarations to

	struct tty_struct *tty = tty_port_tty_get(&port->port);
	unsigned int index = port->port_number;
	int status = 0;

>  	tty = tty_port_tty_get(&port->port);
>  	index = port->port_number;
>  
> @@ -1268,8 +1268,8 @@ static void qt_set_termios(struct tty_struct *tty,
>  	if (I_IXOFF(tty) || I_IXON(tty)) {
>  		unsigned char stop_char = STOP_CHAR(tty);
>  		unsigned char start_char = START_CHAR(tty);
> -		status =
> -		    box_set_sw_flow_ctrl(port->serial, index, stop_char,
> +
> +		status = box_set_sw_flow_ctrl(port->serial, index, stop_char,
>  				      start_char);

Please realign start_char to the open parenthesis

		status = box_set_sw_flow_ctrl(port->serial, index, stop_char,
					      start_char);


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/