linux-kernel - Re: [PATCH] avr32: replace simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140331065637.GA21509@samfundet.no>
Date:	Mon, 31 Mar 2014 08:56:37 +0200
From:	Hans-Christian Egtvedt <egtvedt@...fundet.no>
To:	Alexey Dobriyan <adobriyan@...il.com>
Cc:	artagnon@...il.com, Linux Kernel <linux-kernel@...r.kernel.org>,
	hskinnemoen@...il.com
Subject: Re: [PATCH] avr32: replace simple_strtoul() with kstrtoul()

Around Wed 19 Mar 2014 12:52:35 +0300 or thereabout, Alexey Dobriyan wrote:
>> - val = simple_strtoul(buf, &endp, 0);
>> - if (endp == buf || val > 0x3f)
>> - return -EINVAL;
>> + ret = kstrtoul(buf, 0, &val);
>> + if (ret)
>> + return ret;
>>   val = (val << 12) | (sysreg_read(PCCR) & 0xfffc0fff);
> 
> you removed 0x3f check
> 
> this conversion is not trivial as it seems

Is anybody going to update this patch? I planned to push early this round, as
others are waiting for AVR32 changes.

-- 
Best regards,
Hans-Christian Egtvedt
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/