linux-kernel - Re: [PATCH 19/55] scsi: Mark function as static in isci/phy.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140331093628.GB1202@leaf>
Date:	Mon, 31 Mar 2014 02:36:28 -0700
From:	Josh Triplett <josh@...htriplett.org>
To:	"Dorau, Lukasz" <lukasz.dorau@...el.com>
Cc:	Rashika Kheria <rashika.kheria@...il.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	intel-linux-scu <intel-linux-scu@...el.com>,
	"Patelczyk, Maciej" <maciej.patelczyk@...el.com>,
	"Jiang, Dave" <dave.jiang@...el.com>,
	"James E.J. Bottomley" <JBottomley@...allels.com>,
	"linux-scsi@...r.kernel.org" <linux-scsi@...r.kernel.org>,
	"Paszkiewicz, Artur" <artur.paszkiewicz@...el.com>
Subject: Re: [PATCH 19/55] scsi: Mark function as static in isci/phy.c

On Mon, Mar 31, 2014 at 08:54:49AM +0000, Dorau, Lukasz wrote:
> On Saturday, March 29, 2014 7:04 PM Rashika Kheria <rashika.kheria@...il.com> wrote:
> > 
> > Mark function as static in isci/phy.c because it is not used outside
> > this file.
> > 
> > This eliminates the following warning in isci/phy.c:
> > drivers/scsi/isci/phy.c:672:6: warning: no previous prototype for
> > ‘scu_link_layer_set_txcomsas_timeout’ [-Wmissing-prototypes]
> > 
> > Signed-off-by: Rashika Kheria <rashika.kheria@...il.com>
> > Reviewed-by: Josh Triplett <josh@...htriplett.org>
> 
> Acked-by: Lukasz Dorau <lukasz.dorau@...el.com>

Since you're a maintainer of the driver in question, can you accept the
three patches you acked, or would you suggest that they go through
another tree?

- Josh Triplett
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/