linux-kernel - Re: [PATCH] pci: changed '...pci_bus* bus' to '...pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 31 Mar 2014 10:49:28 +0100
From:	Liviu Dudau <Liviu.Dudau@....com>
To:	Ryan <ryan@...fo.org>
Cc:	"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pci: changed '...pci_bus* bus' to '...pci_bus *bus'

On Sun, Mar 30, 2014 at 09:59:28PM +0100, Ryan wrote:
> Hello,
> 
> This is my first patch.  I'm looking for feedback pertaining to my
> submission that way I can submit more patches correctly in the future. 
> Any constructive feedback is welcome.

Documentation/SubmittingPatches is always a good source of good practices.

> 
> I have one question in particular regarding the 'Sign by' section in the
> git commit message.  Am I suppose to add a 'Sign by' line for myself or
> is that for the core kernel team?

You can find Section 12 of the file mentioned above relevant. Signed-off-by
is a way of telling others that you have the right to release the code that
you are posting *and* (IMHO) will take responsability for the modifications you
make (i.e. if someone will complain about things breaking up you will fix them).

Best regards,
Liviu

> 
> Thank you for time and feedback,
> Ryan
> 
> On 03/28/2014 03:13 PM, Ryan Desfosses wrote:
> >    change made to resolve following checkpatch message:
> >        drivers/pci/pci.c:109: ERROR: "foo* bar" should be "foo *bar"
> > ---
> >  drivers/pci/pci.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c
> > index fdbc294..a50d542 100644
> > --- a/drivers/pci/pci.c
> > +++ b/drivers/pci/pci.c
> > @@ -106,7 +106,7 @@ static bool pcie_ari_disabled;
> >   * Given a PCI bus, returns the highest PCI bus number present in the set
> >   * including the given PCI bus and its list of child PCI buses.
> >   */
> > -unsigned char pci_bus_max_busnr(struct pci_bus* bus)
> > +unsigned char pci_bus_max_busnr(struct pci_bus *bus)
> >  {
> >  	struct list_head *tmp;
> >  	unsigned char max, n;
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-pci" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

-- 
====================
| I would like to |
| fix the world,  |
| but they're not |
| giving me the   |
 \ source code!  /
  ---------------
    ¯\_(ツ)_/¯

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/