linux-kernel - Re: Staging:et131x: change memcpy() ether_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAOiHx=kvEX5ay+eXf-+6tdN=oNNKTGfCq6DA=JHTS-WnA3tKGQ@mail.gmail.com>
Date:	Mon, 31 Mar 2014 14:47:58 +0200
From:	Jonas Gorski <jogo@...nwrt.org>
To:	Dan Carpenter <dan.carpenter@...cle.com>
Cc:	paulmcquad <paulmcquad@...il.com>,
	"Zhao, Gang" <gamerh2o@...il.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	devel@...verdev.osuosl.org,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: Staging:et131x: change memcpy() ether_addr_copy()

On Mon, Mar 31, 2014 at 10:56 AM, Dan Carpenter
<dan.carpenter@...cle.com> wrote:
> On Fri, Mar 28, 2014 at 10:27:22PM +0000, paulmcquad wrote:
>> >From 63f3c8948d5264ab22695502b201ff50edb9028d Mon Sep 17 00:00:00 2001
>> From: Paul McQuade <paulmcquad@...il.com>
>> Date: Fri, 28 Mar 2014 22:16:22 +0000
>> Subject: [PATCH] Staging:et131x: change memcpy()  ether_addr_copy()
>
> Don't include this header block.
>
>>
>> replace memcpy() with ether_addr_copy()
>> make checkpatch.pl clean
>
> Patch doesn't apply to linux-next.
>
>> @@ -4337,7 +4337,7 @@ static void et131x_multicast(struct net_device *netdev)
>>      netdev_for_each_mc_addr(ha, netdev) {
>>          if (i == NIC_MAX_MCAST_LIST)
>>              break;
>> -        memcpy(adapter->multicast_list[i++], ha->addr, ETH_ALEN);
>> +    ether_addr_copy(adapter->multicast_list[i++], ha->addr, ETH_ALEN);
>
> There is an indenting error here.

Also ether_addr_copy does not have a third argument, so it would not
even compile.


Regards
Jonas
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/