linux-kernel - Re: [PATCH] staging/wlan-ng fix small coding style issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140331134227.GP6991@mwanda>
Date:	Mon, 31 Mar 2014 16:42:27 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Denis Pithon <denis.pithon@...il.com>
Cc:	gregkh@...uxfoundation.org, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org, khoroshilov@...ras.ru
Subject: Re: [PATCH] staging/wlan-ng fix small coding style issue

On Mon, Mar 31, 2014 at 03:13:23PM +0200, Denis Pithon wrote:
> Signed-off-by: Denis Pithon <denis.pithon@...il.com>

Changeglog sucks.  It doesn't even exist, actually.  What coding style
issue did you fix?

> ---
>  drivers/staging/wlan-ng/prism2usb.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/staging/wlan-ng/prism2usb.c b/drivers/staging/wlan-ng/prism2usb.c
> index 4739c14..ccb2c2e 100644
> --- a/drivers/staging/wlan-ng/prism2usb.c
> +++ b/drivers/staging/wlan-ng/prism2usb.c
> @@ -293,6 +293,7 @@ static int prism2sta_suspend(struct usb_interface *interface,
>  	hfa384x_t *hw = NULL;
>  	wlandevice_t *wlandev;
>  	wlandev = (wlandevice_t *) usb_get_intfdata(interface);
> +
>  	if (!wlandev)
>  		return -ENODEV;

The blank line should go be one line earlier.

	wlandevice_t *wlandev;
	[blank]
	wlandev = (wlandevice_t *) usb_get_intfdata(interface);

>  
> @@ -315,6 +316,7 @@ static int prism2sta_resume(struct usb_interface *interface)
>  	hfa384x_t *hw = NULL;
>  	wlandevice_t *wlandev;
>  	wlandev = (wlandevice_t *) usb_get_intfdata(interface);
> +

Same.

>  	if (!wlandev)
>  		return -ENODEV;

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/