lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20140331155512.GA7217@kroah.com>
Date:	Mon, 31 Mar 2014 08:55:12 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Thomas Vegas <thomas_75@...e-mail.net>
Cc:	joe@...ches.com, devel@...verdev.osuosl.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: serqt_usb2: Fix coding style issues.

On Mon, Mar 31, 2014 at 08:51:04AM +0200, Thomas Vegas wrote:
> Add blank lines after declarations and cleanup initializations.

Patches should do only 1 thing, not multiple things if at all possible.

So this should be 2 patches, not one.  Care to break it up like that and
resend 2 patches instead?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ