linux-kernel - Re: [PATCH net-next v2] net-sysfs: expose number of carrier on/off changes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGVrzcZvR+MWBVTp5g_DoMWe4i7Z4EiUmwpCGBcT9pgqztXu2g@mail.gmail.com>
Date:	Mon, 31 Mar 2014 09:49:52 -0700
From:	Florian Fainelli <f.fainelli@...il.com>
To:	David Decotigny <decot@...glers.com>
Cc:	Stephen Hemminger <stephen@...workplumber.org>,
	"David S. Miller" <davem@...emloft.net>,
	Jamal Hadi Salim <jhs@...atatu.com>,
	"netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Eric Dumazet <edumazet@...gle.com>,
	"Eric W. Biederman" <ebiederm@...ssion.com>,
	Weilong Chen <chenweilong@...wei.com>,
	Jiri Pirko <jiri@...nulli.us>, Amir Vadai <amirv@...lanox.com>,
	Michael Dalton <mwdalton@...gle.com>,
	Al Viro <viro@...iv.linux.org.uk>, Tejun Heo <tj@...nel.org>,
	Eric Dumazet <eric.dumazet@...il.com>
Subject: Re: [PATCH net-next v2] net-sysfs: expose number of carrier on/off changes

Hi David,

2014-03-30 8:18 GMT-07:00 David Decotigny <decot@...glers.com>:
> Hi all,
>
> As Eric mentioned, this is a per-link counter. I am not sure an
> aggregate stat would be as useful.
>
> As suggested by Florian, I'm planning to add a doc. As far as I can
> tell, I think it goes beyond just documenting this new counter: I
> believe sysfs-class-net needs to be added as a whole.

Right, I sort of started to do that here:
http://patchwork.ozlabs.org/patch/334888/
Once this gets accepted, I plan on documenting the other sysfs
attributes in statistics/ and queues/ in particular

>
> Stephen: I have a patch for iproute2, I was planning to send it after
> we're done with this one, unless you want it now. Also, should I
> document this IFLA thing, where would be best?
>
> On Sat, Mar 29, 2014 at 6:50 PM, Eric Dumazet <eric.dumazet@...il.com> wrote:
>> On Sat, 2014-03-29 at 18:36 -0700, Stephen Hemminger wrote:
>>> On Sat, 29 Mar 2014 09:48:35 -0700
>>> David Decotigny <decot@...glers.com> wrote:
>>>
>>> > This allows to monitor carrier on/off transitions and detect link
>>> > flapping issues:
>>> >  - new /sys/class/net/X/carrier_changes
>>> >  - new rtnetlink IFLA_CARRIER_CHANGES (getlink)
>>> >
>>> > Tested:
>>> >   - grep . /sys/class/net/*/carrier_changes
>>> >     + ip link set dev X down/up
>>> >     + plug/unplug cable
>>> >   - updated iproute2: prints IFLA_CARRIER_CHANGES
>>> >   - iproute2 20121211-2 (debian): unchanged behavior
>>> >
>>> > Signed-off-by: David Decotigny <decot@...glers.com>
>>>
>>> Is there a related SNMP MIB variable? should there be?
>>
>> I don't think we have any SNMP MIB variable for devices ?
>>
>> It seems "ip link" is the facto standard.
>>
>> (BTW we put BusyPollRxPackets in TcpExt group, this was an error IMHO)
>>
>>



-- 
Florian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/