linux-kernel - Re: [PATCH V4 RESEND] Support Thinkpad X1 Carbon 2nd gen's adaptive keyboard

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Mon, 31 Mar 2014 14:49:49 -0300
From:	Henrique de Moraes Holschuh <hmh@....eng.br>
To:	Shuduo Sang <shuduo.sang@...onical.com>,
	matthew.garrett@...ula.com, ibm-acpi-devel@...ts.sourceforge.net,
	platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Cc:	bruce.ma@...onical.com
Subject: Re: [PATCH V4 RESEND] Support Thinkpad X1 Carbon 2nd gen's adaptive
 keyboard

On Tue, Mar 11, 2014, at 8:01, Shuduo Sang wrote:
> Resend patch V4. Support Thinkpad X1 Carbon 2nd generation's adaptive
> keyboard.
> 
> Hi Henrique, could you please have a chance to review it?

I am unable to do a full review right now, but we can always adjust
minor details of the feature with later patches and the previous reviews
did help clean up the feature.

However: as far as I am concerned, this is an experimental feature until
it matures for a while.  I'd rather we plug this somehow to the
thinkpad-acpi input map, for example.

Acked-by: Henrique de Moraes Holschuh <hmh@....eng.br>

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/