linux-kernel - Re: [PATCH v2] Staging: ft1000-usb: fixed a few code style issues

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20140401063444.GA10337@gmail.com>
Date:	Tue, 1 Apr 2014 08:34:44 +0200
From:	Anders Darander <anders.darander@...il.com>
To:	Greg KH <gregkh@...uxfoundation.org>
Cc:	devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] Staging: ft1000-usb: fixed a few code style issues

* Greg KH <gregkh@...uxfoundation.org> [140401 00:53]:

> On Mon, Mar 31, 2014 at 08:26:28AM +0200, Anders Darander wrote:
> > Fixed a few code style issues, particularly:

> > Add do {} while (0) wrapper around seq_* macros.
> > Change printk(KERN_WARN...) to netdev_warn(...).

> That's 2 different things, please split this up into 2 different
> patches.

Split up patches on their way.

> Remember, one patch does one thing.

Sure.

In this case I deemed them to be small and though not the same, but
still mosly coding style issues. Though, I can certainly see that the
printk to netdev_warn actually adds more than just a coding style
clean-up.

Cheers,
Anders

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/