lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 01 Apr 2014 09:02:04 +0200 From: Krzysztof Kozlowski <k.kozlowski@...sung.com> To: Axel Lin <axel.lin@...ics.com> Cc: Mark Brown <broonie@...nel.org>, Sachin Kamat <sachin.kamat@...aro.org>, Sangbeom Kim <sbkim73@...sung.com>, Liam Girdwood <lgirdwood@...il.com>, linux-kernel@...r.kernel.org Subject: Re: [PATCH 2/2] regulator: s2mps11: Don't check enable_shift before setting enable ramp rate On Fri, 2014-03-21 at 16:16 +0800, Axel Lin wrote: > Current code misses updating the register when enable_shift is 0. > e.g. S2MPS11_BUCK9_RAMP_SHIFT and S2MPS11_BUCK6_RAMP_EN_SHIFT are 0. > > Signed-off-by: Axel Lin <axel.lin@...ics.com> > --- > drivers/regulator/s2mps11.c | 12 +++++------- > 1 file changed, 5 insertions(+), 7 deletions(-) Looks good. Reviewed-by: Krzysztof Kozlowski <k.kozlowski@...sung.com> Best regards, Krzysztof > diff --git a/drivers/regulator/s2mps11.c b/drivers/regulator/s2mps11.c > index 68fd547..e713c16 100644 > --- a/drivers/regulator/s2mps11.c > +++ b/drivers/regulator/s2mps11.c > @@ -202,13 +202,11 @@ static int s2mps11_set_ramp_delay(struct regulator_dev *rdev, int ramp_delay) > if (!ramp_enable) > goto ramp_disable; > > - if (enable_shift) { > - ret = regmap_update_bits(rdev->regmap, S2MPS11_REG_RAMP, > - 1 << enable_shift, 1 << enable_shift); > - if (ret) { > - dev_err(&rdev->dev, "failed to enable ramp rate\n"); > - return ret; > - } > + ret = regmap_update_bits(rdev->regmap, S2MPS11_REG_RAMP, > + 1 << enable_shift, 1 << enable_shift); > + if (ret) { > + dev_err(&rdev->dev, "failed to enable ramp rate\n"); > + return ret; > } > > ramp_val = get_ramp_delay(ramp_delay); -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists