linux-kernel - Re: [Xen-devel] [PATCH] xen: fix memory leak in __xen_pcibk_add_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <533A85A70200007800003F59@nat28.tlf.novell.com>
Date:	Tue, 01 Apr 2014 08:23:51 +0100
From:	"Jan Beulich" <JBeulich@...e.com>
To:	"Daeseok Youn" <daeseok.youn@...il.com>, <konrad.wilk@...cle.com>
Cc:	<david.vrabel@...rix.com>, <xen-devel@...ts.xenproject.org>,
	<boris.ostrovsky@...cle.com>, <joe@...ches.com>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [Xen-devel] [PATCH] xen: fix memory leak in
 __xen_pcibk_add_pci_dev()

>>> On 31.03.14 at 12:08, <daeseok.youn@...il.com> wrote:

> It need to free dev_entry when it failed to assign to a new
> slot on the virtual PCI bus.
> 
> smatch says:
>  drivers/xen/xen-pciback/vpci.c:142 __xen_pcibk_add_pci_dev() warn:
> possible memory leak of 'dev_entry'
> 
> Signed-off-by: Daeseok Youn <daeseok.youn@...il.com>

Reviewed-by: Jan Beulich <jbeulich@...e.com>

albeit the solution is not ideal:

> --- a/drivers/xen/xen-pciback/vpci.c
> +++ b/drivers/xen/xen-pciback/vpci.c
> @@ -130,6 +130,7 @@ static int __xen_pcibk_add_pci_dev(struct 
> xen_pcibk_device *pdev,
>  	err = -ENOMEM;
>  	xenbus_dev_fatal(pdev->xdev, err,
>  			 "No more space on root virtual PCI bus");
> +	kfree(dev_entry);
>  
>  unlock:
>  	mutex_unlock(&vpci_dev->lock);

The kfree() invocation would better be placed outside the locked
region (e.g. in an else to the "if (!err)" a little further down).

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/