linux-kernel - Re: [PATCH] pata_samsung_cf: fix ata_host

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 01 Apr 2014 10:18:46 +0900
From:	Jingoo Han <jg1.han@...sung.com>
To:	'Bartlomiej Zolnierkiewicz' <b.zolnierkie@...sung.com>,
	'Tejun Heo' <tj@...nel.org>
Cc:	'Ben Dooks' <ben-linux@...ff.org>,
	'Kukjin Kim' <kgene.kim@...sung.com>,
	linux-ide@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	'Jingoo Han' <jg1.han@...sung.com>
Subject: Re: [PATCH] pata_samsung_cf: fix ata_host_activate() failure handling

On Tuesday, April 01, 2014 2:53 AM, Tejun Heo wrote:
> 
> Add missing clk_disable() call to ata_host_activate() failure path.
> 
> Cc: Ben Dooks <ben-linux@...ff.org>
> Cc: Kukjin Kim <kgene.kim@...sung.com>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@...sung.com>

Reviewed-by: Jingoo Han <jg1.han@...sung.com>

Best regards,
Jingoo Han

> ---
>  drivers/ata/pata_samsung_cf.c |   10 +++++++---
>  1 file changed, 7 insertions(+), 3 deletions(-)
> 
> Index: b/drivers/ata/pata_samsung_cf.c
> ===================================================================
> --- a/drivers/ata/pata_samsung_cf.c	2014-03-14 16:45:04.344724378 +0100
> +++ b/drivers/ata/pata_samsung_cf.c	2014-03-31 18:31:58.083631437 +0200
> @@ -594,9 +594,13 @@ static int __init pata_s3c_probe(struct
> 
>  	platform_set_drvdata(pdev, host);
> 
> -	return ata_host_activate(host, info->irq,
> -			info->irq ? pata_s3c_irq : NULL,
> -			0, &pata_s3c_sht);
> +	ret = ata_host_activate(host, info->irq,
> +				info->irq ? pata_s3c_irq : NULL,
> +				0, &pata_s3c_sht);
> +	if (ret)
> +		goto stop_clk;
> +
> +	return 0;
> 
>  stop_clk:
>  	clk_disable(info->clk);
> 
> --

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/