linux-kernel - Re: [PATCH v2] xen: fix memory leak in __xen_pcibk_add_pci

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <533AB59A020000780000409F@nat28.tlf.novell.com>
Date:	Tue, 01 Apr 2014 11:48:26 +0100
From:	"Jan Beulich" <JBeulich@...e.com>
To:	"Daeseok Youn" <daeseok.youn@...il.com>, <konrad.wilk@...cle.com>
Cc:	<david.vrabel@...rix.com>, <xen-devel@...ts.xenproject.org>,
	<boris.ostrovsky@...cle.com>, <joe@...ches.com>,
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v2] xen: fix memory leak in
 __xen_pcibk_add_pci_dev()

>>> On 01.04.14 at 12:15, <daeseok.youn@...il.com> wrote:

> It need to free dev_entry when it failed to assign to a new
> slot on the virtual PCI bus.
> 
> smatch says:
>  drivers/xen/xen-pciback/vpci.c:142 __xen_pcibk_add_pci_dev() warn:
> possible memory leak of 'dev_entry'
> 
> Signed-off-by: Daeseok Youn <daeseok.youn@...il.com>

As before
Reviewed-by: Jan Beulich <jbeulich@...e.com>

> ---
> v2: The kfree() invocation is moved outside the locked region.
> 
>  drivers/xen/xen-pciback/vpci.c |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/xen/xen-pciback/vpci.c b/drivers/xen/xen-pciback/vpci.c
> index 3165ce3..51afff9 100644
> --- a/drivers/xen/xen-pciback/vpci.c
> +++ b/drivers/xen/xen-pciback/vpci.c
> @@ -137,6 +137,8 @@ unlock:
>  	/* Publish this device. */
>  	if (!err)
>  		err = publish_cb(pdev, 0, 0, PCI_DEVFN(slot, func), devid);
> +	else
> +		kfree(dev_entry);
>  
>  out:
>  	return err;
> -- 
> 1.7.4.4



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/