| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <1396368519-12728-78-git-send-email-kamal@canonical.com> Date: Tue, 1 Apr 2014 09:08:30 -0700 From: Kamal Mostafa <kamal@...onical.com> To: linux-kernel@...r.kernel.org, stable@...r.kernel.org, kernel-team@...ts.ubuntu.com Cc: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com>, Takashi Iwai <tiwai@...e.de>, Kamal Mostafa <kamal@...onical.com> Subject: [PATCH 3.8 77/86] ALSA: compress: Pass through return value of open ops callback 3.8.13.21 -stable review patch. If anyone has any objections, please let me know. ------------------ From: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com> commit 749d32237bf39e6576dd95bfdf24e4378e51716c upstream. The snd_compr_open function would always return 0 even if the compressed ops open function failed, obviously this is incorrect. Looks like this was introduced by a small typo in: commit a0830dbd4e42b38aefdf3fb61ba5019a1a99ea85 ALSA: Add a reference counter to card instance This patch returns the value from the compressed op as it should. Signed-off-by: Charles Keepax <ckeepax@...nsource.wolfsonmicro.com> Acked-by: Vinod Koul <vinod.koul@...el.com> Signed-off-by: Takashi Iwai <tiwai@...e.de> Signed-off-by: Kamal Mostafa <kamal@...onical.com> --- sound/core/compress_offload.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sound/core/compress_offload.c b/sound/core/compress_offload.c index a388a87..918d2fd 100644 --- a/sound/core/compress_offload.c +++ b/sound/core/compress_offload.c @@ -131,7 +131,7 @@ static int snd_compr_open(struct inode *inode, struct file *f) kfree(data); } snd_card_unref(compr->card); - return 0; + return ret; } static int snd_compr_free(struct inode *inode, struct file *f) -- 1.8.3.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists