linux-kernel - Re: [PATCH] tc: account for device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.11.1404010108270.27402@eddie.linux-mips.org>
Date:	Tue, 1 Apr 2014 01:30:56 +0100 (BST)
From:	"Maciej W. Rozycki" <macro@...ux-mips.org>
To:	Levente Kurusa <levex@...ux.com>,
	Ralf Baechle <ralf@...ux-mips.org>
cc:	LKML <linux-kernel@...r.kernel.org>, linux-mips@...ux-mips.org
Subject: Re: [PATCH] tc: account for device_register() failure

On Fri, 15 Nov 2013, Levente Kurusa wrote:

> This patch makes the TURBOchannel driver bail out if the call
> to device_register() failed.
> 
> Signed-off-by: Levente Kurusa <levex@...ux.com>

Acked-by: Maciej W. Rozycki <macro@...ux-mips.org>

This fixes some build warnings:

drivers/tc/tc.c: In function 'tc_bus_add_devices':
drivers/tc/tc.c:132: warning: ignoring return value of 'device_register', 
declared with attribute warn_unused_result
drivers/tc/tc.c: In function 'tc_init':
drivers/tc/tc.c:151: warning: ignoring return value of 'device_register', 
declared with attribute warn_unused_result

Levente, thanks for your fix and apologies for the long RTT -- can you 
please resend your patch to <linux-mips@...ux-mips.org> and Ralf so that 
it'll be pulled via the MIPS tree?  I'll post a follow-up update to fix 
some issues with `tc_init' that I noticed thanks to your change.

> ---
>  tc.c |   10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/tc/tc.c b/drivers/tc/tc.c
> index a8aaf6a..6b3a038 100644
> --- a/drivers/tc/tc.c
> +++ b/drivers/tc/tc.c
> @@ -129,7 +129,10 @@ static void __init tc_bus_add_devices(struct tc_bus *tbus)
> 
>  		tc_device_get_irq(tdev);
> 
> -		device_register(&tdev->dev);
> +		if (device_register(&tdev->dev)) {
> +			put_device(&tdev->dev);
> +			goto out_err;
> +		}
>  		list_add_tail(&tdev->node, &tbus->devices);
> 
>  out_err:
> @@ -148,7 +151,10 @@ static int __init tc_init(void)
> 
>  	INIT_LIST_HEAD(&tc_bus.devices);
>  	dev_set_name(&tc_bus.dev, "tc");
> -	device_register(&tc_bus.dev);
> +	if (device_register(&tc_bus.dev)) {
> +		put_device(&tc_bus.dev);
> +		return 0;	
> +	}
> 
>  	if (tc_bus.info.slot_size) {
>  		unsigned int tc_clock = tc_get_speed(&tc_bus) / 100000;
> 

  Maciej
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/