linux-kernel - Re: [PATCH 1/3] staging: vt6655: fix DBG_PRT and PRINT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140401170641.GA5353@kroah.com>
Date:	Tue, 1 Apr 2014 10:06:41 -0700
From:	Greg KH <gregkh@...uxfoundation.org>
To:	Guido Martínez <guido@...guardiasur.com.ar>
Cc:	Walter Lozano <walter@...guardiasur.com.ar>,
	driverdev-devel@...uxdriverproject.org,
	linux-kernel@...r.kernel.org,
	Forest Bond <forest@...ttletooquiet.net>,
	Ezequiel García 
	<ezequiel@...guardiasur.com.ar>
Subject: Re: [PATCH 1/3] staging: vt6655: fix DBG_PRT and PRINT_K macros

On Tue, Apr 01, 2014 at 01:56:02PM -0300, Guido Martínez wrote:
> On Tue, Apr 01, 2014 at 09:33:00AM -0700, Greg KH wrote:
> > On Tue, Apr 01, 2014 at 09:52:11AM -0300, Guido Martínez wrote:
> > > Parenthesize both macros so they will not break program logic if used
> > > within another 'if'. Also fix a usage of DBG_PRT with a missing
> > > semicolon.
> > > 
> > > Signed-off-by: Guido Martínez <guido@...guardiasur.com.ar>
> > > ---
> > >  drivers/staging/vt6655/device.h | 4 ++--
> > >  drivers/staging/vt6655/wpactl.c | 2 +-
> > >  2 files changed, 3 insertions(+), 3 deletions(-)
> > > 
> > > diff --git a/drivers/staging/vt6655/device.h b/drivers/staging/vt6655/device.h
> > > index 062c3a3..483b017 100644
> > > --- a/drivers/staging/vt6655/device.h
> > > +++ b/drivers/staging/vt6655/device.h
> > > @@ -148,8 +148,8 @@
> > >  
> > >  /*---------------------  Export Types  ------------------------------*/
> > >  
> > > -#define DBG_PRT(l, p, args...) { if (l <= msglevel) printk(p, ##args); }
> > > -#define PRINT_K(p, args...) { if (PRIVATE_Message) printk(p, ##args); }
> > > +#define DBG_PRT(l, p, args...) ({ if (l <= msglevel) printk(p, ##args); })
> > > +#define PRINT_K(p, args...) ({ if (PRIVATE_Message) printk(p, ##args); })
> > 
> > I would much rather see these "fixed" by removing them entirely and
> > using the in-kernel calls instead (netdev_* and dev_* where applicable.)
> 
> Sounds OK. Is it ok to do that in another patch?  I made this change on a
> need-to basis because otherwise it was not possible to fix the bracing
> style.

Yes, that would be fine.

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/