linux-kernel - Re: [PATCH 3/4] asmlinkage, x86: Add explicit _

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 1 Apr 2014 11:53:23 -0700
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Andi Kleen <andi@...stfloor.org>
Cc:	"the arch/x86 maintainers" <x86@...nel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Andi Kleen <ak@...ux.intel.com>,
	Herbert Xu <herbert@...dor.apana.org.au>
Subject: Re: [PATCH 3/4] asmlinkage, x86: Add explicit __visible to arch/x86/crypto/*

On Tue, Apr 1, 2014 at 10:32 AM, Andi Kleen <andi@...stfloor.org> wrote:
>
> -asmlinkage void aes_enc_blk(struct crypto_aes_ctx *ctx, u8 *out, const u8 *in);
> -asmlinkage void aes_dec_blk(struct crypto_aes_ctx *ctx, u8 *out, const u8 *in);
> +asmlinkage __visible void aes_enc_blk(struct crypto_aes_ctx *ctx, u8 *out, const u8 *in);
> +asmlinkage __visible void aes_dec_blk(struct crypto_aes_ctx *ctx, u8 *out, const u8 *in);

This seems to be more of the same "__visible in declaration" badness.

Don't do it.

As far as I can tell, the only point of "__visible" is on C symbols
called from assembly language.

You're adding them to assembly routines called from C, which is
exactly the wrong way around, and pointless. And it's worse than
pointless churn, it just confuses people, and shows that you are
confused about the meaning of it.

Again, it seems to be because you've mentally tied "asmlinkage"
together with "__visible", but they are totally disjoint. One is about
calling conventions, the other is about the C compiler not hiding the
function when using -fwhole-program.

STOP CONFUSING THE TWO. They are independent and have absolutely
*NOTHING* to do with each other.

             Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/