linux-kernel - Re: Bug in ks8851.c

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20140401.181355.1375673242692769955.davem@davemloft.net>
Date:	Tue, 01 Apr 2014 18:13:55 -0400 (EDT)
From:	David Miller <davem@...emloft.net>
To:	Max.Nekludov@...ter.com
Cc:	torvalds@...ux-foundation.org, netdev@...r.kernel.org,
	sboyd@...eaurora.org, mjr@...wisc.edu, jiri@...nulli.us,
	linux-kernel@...r.kernel.org, trivial@...tcorp.com.au
Subject: Re: Bug in ks8851.c

From: "Nekludov, Max" <Max.Nekludov@...ter.com>
Date: Tue, 1 Apr 2014 15:41:58 +0000

> Reset on RX failure and TX timeout.
> 
> Electromagnetic noice can make device to not send TX interrupts.
> As result outgoing queue will be suspended forever.
> Also EMI can raise RX interrupt with zero value in KS_RXFC register.
> 
> Patch attached.

netdev@...r.kernel.org and the driver maintainer (as listed in
MAINTAINERS) is sufficient for submitting this patch, lists
such as 'trivial' and sending such patches to Linus directly
is not really appropriate.

As per your patch, please do not submit it as an attachment,
as per Documentation/SubmittingPatches, it should be the main
content with the commit message header line being in your
Subject.

Furthermore, in:

+static void ks8851_wdt_work(struct delayed_work *work)
+{
+	struct ks8851_net *ks = container_of(work, struct ks8851_net, wdt_work);
+	mutex_lock(&ks->lock);

You should have an empty line beteen local variable declarations
and where real code starts.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/