linux-kernel - Re: [PATCH] staging: lirc: fix NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20140402091334.GV6991@mwanda>
Date:	Wed, 2 Apr 2014 12:13:34 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Daeseok Youn <daeseok.youn@...il.com>
Cc:	m.chehab@...sung.com, devel@...verdev.osuosl.org,
	bernat.ada@...il.com, gregkh@...uxfoundation.org,
	jarod@...sonet.com, linux-kernel@...r.kernel.org,
	paulmck@...ux.vnet.ibm.com, mtrompou@...il.com,
	linux-media@...r.kernel.org
Subject: Re: [PATCH] staging: lirc: fix NULL pointer dereference

On Wed, Apr 02, 2014 at 05:18:39PM +0900, Daeseok Youn wrote:
> 
> coccicheck says:
>  drivers/staging/media/lirc/lirc_igorplugusb.c:226:15-21:
> ERROR: ir is NULL but dereferenced.
> 
> Signed-off-by: Daeseok Youn <daeseok.youn@...il.com>
> ---
>  drivers/staging/media/lirc/lirc_igorplugusb.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/staging/media/lirc/lirc_igorplugusb.c b/drivers/staging/media/lirc/lirc_igorplugusb.c
> index f508a13..0ef393b 100644
> --- a/drivers/staging/media/lirc/lirc_igorplugusb.c
> +++ b/drivers/staging/media/lirc/lirc_igorplugusb.c
> @@ -223,8 +223,8 @@ static int unregister_from_lirc(struct igorplug *ir)
>  	int devnum;
>  
>  	if (!ir) {
> -		dev_err(&ir->usbdev->dev,
> -			"%s: called with NULL device struct!\n", __func__);
> +		printk(DRIVER_NAME "%s: called with NULL device struct!\n",
> +		       __func__);


It should be pr_err() or something.  But actually "ir" can't be NULL so
just delete the whole condition.


>  		return -EINVAL;
>  	}

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/