linux-kernel - Re: [PATCH] v4l2-pci-skeleton: fix typo while retrieving the skel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <533BDAA7.5070704@xs4all.nl>
Date:	Wed, 02 Apr 2014 11:38:47 +0200
From:	Hans Verkuil <hverkuil@...all.nl>
To:	"Lad, Prabhakar" <prabhakar.csengg@...il.com>
CC:	LMML <linux-media@...r.kernel.org>,
	LKML <linux-kernel@...r.kernel.org>,
	Hans Verkuil <hans.verkuil@...co.com>,
	Mauro Carvalho Chehab <m.chehab@...sung.com>,
	LDOC <linux-doc@...r.kernel.org>, Rob Landley <rob@...dley.net>
Subject: Re: [PATCH] v4l2-pci-skeleton: fix typo while retrieving the skel_buffer

On 03/24/14 18:51, Lad, Prabhakar wrote:
> From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
> 
> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@...il.com>
> ---
>  Documentation/video4linux/v4l2-pci-skeleton.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/Documentation/video4linux/v4l2-pci-skeleton.c b/Documentation/video4linux/v4l2-pci-skeleton.c
> index 3a1c0d2..61a56f4 100644
> --- a/Documentation/video4linux/v4l2-pci-skeleton.c
> +++ b/Documentation/video4linux/v4l2-pci-skeleton.c
> @@ -87,7 +87,7 @@ struct skel_buffer {
>  
>  static inline struct skel_buffer *to_skel_buffer(struct vb2_buffer *vb2)
>  {
> -	return container_of(vb2, struct skel_buffer, vb);
> +	return container_of(vb2, struct skel_buffer, vb2);

Why is this a type? The vb2_buffer member in struct skel_buffer is called
'vb', so this should be correct.

Regards,

	Hans

>  }
>  
>  static const struct pci_device_id skeleton_pci_tbl[] = {
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/