linux-kernel - Re: [PATCH] staging: lirc: fix NULL pointer dereference

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 2 Apr 2014 18:50:49 +0900
From:	DaeSeok Youn <daeseok.youn@...il.com>
To:	m.chehab@...sung.com
Cc:	Dan Carpenter <dan.carpenter@...cle.com>,
	devel <devel@...verdev.osuosl.org>,
	Andreea Bernat <bernat.ada@...il.com>,
	Greg KH <gregkh@...uxfoundation.org>, jarod@...sonet.com,
	linux-kernel <linux-kernel@...r.kernel.org>,
	Paul McKenney <paulmck@...ux.vnet.ibm.com>,
	Martina Trompouki <mtrompou@...il.com>,
	linux-media@...r.kernel.org
Subject: Re: [PATCH] staging: lirc: fix NULL pointer dereference

Please drop this patch.

I made a patch as Dan's comment and sent it.

Thanks.
Daeseok Youn.

2014-04-02 18:41 GMT+09:00 DaeSeok Youn <daeseok.youn@...il.com>:
> You are right. remove whole thing and send it again.
>
> Thanks.
> Daeseok Youn
>
> 2014-04-02 18:13 GMT+09:00 Dan Carpenter <dan.carpenter@...cle.com>:
>> On Wed, Apr 02, 2014 at 05:18:39PM +0900, Daeseok Youn wrote:
>>>
>>> coccicheck says:
>>>  drivers/staging/media/lirc/lirc_igorplugusb.c:226:15-21:
>>> ERROR: ir is NULL but dereferenced.
>>>
>>> Signed-off-by: Daeseok Youn <daeseok.youn@...il.com>
>>> ---
>>>  drivers/staging/media/lirc/lirc_igorplugusb.c |    4 ++--
>>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>>
>>> diff --git a/drivers/staging/media/lirc/lirc_igorplugusb.c b/drivers/staging/media/lirc/lirc_igorplugusb.c
>>> index f508a13..0ef393b 100644
>>> --- a/drivers/staging/media/lirc/lirc_igorplugusb.c
>>> +++ b/drivers/staging/media/lirc/lirc_igorplugusb.c
>>> @@ -223,8 +223,8 @@ static int unregister_from_lirc(struct igorplug *ir)
>>>       int devnum;
>>>
>>>       if (!ir) {
>>> -             dev_err(&ir->usbdev->dev,
>>> -                     "%s: called with NULL device struct!\n", __func__);
>>> +             printk(DRIVER_NAME "%s: called with NULL device struct!\n",
>>> +                    __func__);
>>
>>
>> It should be pr_err() or something.  But actually "ir" can't be NULL so
>> just delete the whole condition.
>>
>>
>>>               return -EINVAL;
>>>       }
>>
>> regards,
>> dan carpenter
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/