linux-kernel - Re: [PATCH 1/2] ttyprintk: Fix wrong tty_unregister

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1396441473.10789.23.camel@chaos.site>
Date:	Wed, 02 Apr 2014 14:24:33 +0200
From:	Jean Delvare <jdelvare@...e.de>
To:	Takashi Iwai <tiwai@...e.de>
Cc:	Arnd Bergmann <arnd@...db.de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Struan Bartlett <struan.bartlett@...il.com>,
	Andreas Schwab <schwab@...ux-m68k.org>,
	gnomes@...rguk.ukuu.org.uk, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] ttyprintk: Fix wrong tty_unregister_driver() call
 in the error path

Le Wednesday 02 April 2014 à 12:29 +0200, Takashi Iwai a écrit :
> ttyprintk driver calls tty_unregister_driver() wrongly in the error
> path of tty_register_driver().  Also, setting ttyprintk_driver to NULL
> is utterly superfluous, so let's get rid of it, too.
> 
> Reported-by: Jean Delvare <jdelvare@...e.de>
> Signed-off-by: Takashi Iwai <tiwai@...e.de>
> ---
>  drivers/char/ttyprintk.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/char/ttyprintk.c b/drivers/char/ttyprintk.c
> index daea84c41743..2a39c5790364 100644
> --- a/drivers/char/ttyprintk.c
> +++ b/drivers/char/ttyprintk.c
> @@ -210,10 +210,8 @@ static int __init ttyprintk_init(void)
>  	return 0;
>  
>  error:
> -	tty_unregister_driver(ttyprintk_driver);
>  	put_tty_driver(ttyprintk_driver);
>  	tty_port_destroy(&tpk_port.port);
> -	ttyprintk_driver = NULL;
>  	return ret;
>  }
>  device_initcall(ttyprintk_init);

Reviewed-by: Jean Delvare <jdelvare@...e.de>

-- 
Jean Delvare
SUSE L3 Support

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/