lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Wed, 2 Apr 2014 21:03:04 +0800 From: Shawn Guo <shawn.guo@...aro.org> To: Nicolin Chen <Guangyu.Chen@...escale.com> CC: <broonie@...nel.org>, <linux-kernel@...r.kernel.org>, <linuxppc-dev@...ts.ozlabs.org>, <alsa-devel@...a-project.org>, <timur@...i.org>, <Li.Xiubo@...escale.com>, <linux-doc@...r.kernel.org>, <devicetree@...r.kernel.org>, <rob@...dley.net>, <galak@...eaurora.org>, <ijc+devicetree@...lion.org.uk>, <mark.rutland@....com>, <pawel.moll@....com>, <robh+dt@...nel.org> Subject: Re: [PATCH v2 2/2] ARM: dts: Append clock bindings for sai2 on VF610 platform On Wed, Apr 02, 2014 at 06:10:20PM +0800, Nicolin Chen wrote: > Since we added fours clock to the DT binding, we should update the current > SAI dts/dtsi so as not to break their functions. > > Signed-off-by: Nicolin Chen <Guangyu.Chen@...escale.com> > --- > arch/arm/boot/dts/vf610.dtsi | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/vf610.dtsi b/arch/arm/boot/dts/vf610.dtsi > index d31ce1b..9fd0007 100644 > --- a/arch/arm/boot/dts/vf610.dtsi > +++ b/arch/arm/boot/dts/vf610.dtsi > @@ -139,8 +139,10 @@ > compatible = "fsl,vf610-sai"; > reg = <0x40031000 0x1000>; > interrupts = <0 86 0x04>; > - clocks = <&clks VF610_CLK_SAI2>; > - clock-names = "sai"; > + clocks = <&clks VF610_CLK_SAI2>, > + <&clks VF610_CLK_SAI2>, > + <&clks 0>, <&clks 0>; So it seems that SAI on vf610 does work with only one clock. So the driver change will break old DTB for vf610? If that's case, we will have to need a new compatible for cases where 4 clocks are needed. Shawn > + clock-names = "bus", "mclk1", "mclk2", "mclk3"; > status = "disabled"; > }; > > -- > 1.8.4 > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists