linux-kernel - Re: [PATCH v2 RESEND 4/4] xhci: Use pci_enable_msix_exact() instead of pci_enable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 2 Apr 2014 17:20:44 +0200
From:	Alexander Gordeev <agordeev@...hat.com>
To:	Mathias Nyman <mathias.nyman@...el.com>
Cc:	Sarah Sharp <sarah.a.sharp@...ux.intel.com>,
	linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-pci@...r.kernel.org,
	Dan Williams <dan.j.williams@...el.com>
Subject: Re: [PATCH v2 RESEND 4/4] xhci: Use pci_enable_msix_exact() instead
 of pci_enable_msix()

On Wed, Apr 02, 2014 at 05:05:13PM +0300, Mathias Nyman wrote:
> On 04/02/2014 02:41 PM, Alexander Gordeev wrote:
> >On Tue, Mar 25, 2014 at 03:27:30PM +0100, Alexander Gordeev wrote:
> >>On Thu, Mar 06, 2014 at 01:56:46PM -0800, Sarah Sharp wrote:
> >>>What do you mean by this sentence?  Are you fixing some bug in those two
> >>>functions, or just cleaning up how they look?  Either way, this should
> >>>really be two patches.
> >>Hi Sarah,
> >>
> >>Any feedback on v2?
> >
> 
> Hi

Thank you for the review, Mathias.

> Thanks for the patches,
> I'll  queue patch 2/2  for usb-linus once 3.15-rc1 comes out.
> 
> But I'm going to omit patch 1/2 because it doesn't really improve
> code readability and doesn't change functionality.

I fail to see how it does not improve the readability. It makes the
way the result returned consistent with the rest of the code and
explicitly returns succeess where it is known 'ret' contains zero.

But it surely up to you :)

> At this stage I'd like to avoid extra patches as much as possible.
> And besides, it adds one extra line of code
> 
> -Mathias

-- 
Regards,
Alexander Gordeev
agordeev@...hat.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/