linux-kernel - Re: [PATCH][next] phy: core: make NULL a valid phy reference if !CONFIG_GENERIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <533C4E8F.20306@ti.com>
Date:	Wed, 2 Apr 2014 13:53:19 -0400
From:	Santosh Shilimkar <santosh.shilimkar@...com>
To:	<balbi@...com>, Greg KH <gregkh@...uxfoundation.org>
CC:	Grygorii Strashko <grygorii.strashko@...com>,
	Kishon Vijay Abraham I <kishon@...com>,
	<linux-kernel@...r.kernel.org>, <linux-usb@...r.kernel.org>,
	<linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH][next] phy: core: make NULL a valid phy reference if !CONFIG_GENERIC_PHY

On Thursday 13 March 2014 05:44 PM, Felipe Balbi wrote:
> Hi,
> 
> On Thu, Mar 13, 2014 at 10:20:24AM -0500, Felipe Balbi wrote:
>> On Thu, Mar 13, 2014 at 01:11:13PM +0200, Grygorii Strashko wrote:
>>> This fixes a regression on Keystone 2 platforms caused by patch
>>> 57303488cd37da58263e842de134dc65f7c626d5
>>> "usb: dwc3: adapt dwc3 core to use Generic PHY Framework" which adds
>>> optional support of generic phy in DWC3 core.
>>>
>>> On Keystone 2 platforms the USB is not working now because
>>> CONFIG_GENERIC_PHY isn't set and, as result, Generic PHY APIs stubs
>>> return -ENOSYS always. The log shows:
>>>  dwc3 2690000.dwc3: failed to initialize core
>>>  dwc3: probe of 2690000.dwc3 failed with error -38
>>>
>>> Hence, fix it by making NULL a valid phy reference in Generic PHY
>>> APIs stubs in the same way as it was done by the patch
>>> 04c2facad8fee66c981a51852806d8923336f362 "drivers: phy: Make NULL
>>> a valid phy reference".
>>>
>>> CC: Kishon Vijay Abraham I <kishon@...com>
>>> CC: Felipe Balbi <balbi@...com>
>>> CC: Santosh Shilimkar <santosh.shilimkar@...com>
>>> Signed-off-by: Grygorii Strashko <grygorii.strashko@...com>
>>
>> nice :-)
>>
>> Acked-by: Felipe Balbi <balbi@...com>
> 
> Greg, if your tree isn't closed yet, could you consider this patch still
> for v3.15 merge window ? Grygorii found a regression on Keystone
> platforms which this patch fixes. Let me know if you need the original
> patch and myself or Kishon can send it to you.
> 
Just checking whether the fix was picked up for the 3.14 merge window ?

Regards,
Santosh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/