linux-kernel - Re: [PATCH 1/1] fs/jfs/jfs_inode.c: atomically set inode->i

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20140402200844.bf9c94540921b7647c75e580@skynet.be>
Date:	Wed, 2 Apr 2014 20:08:44 +0200
From:	Fabian Frederick <fabf@...net.be>
To:	Theodore Ts'o <tytso@....edu>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	akpm <akpm@...ux-foundation.org>,
	jfs-discussion@...ts.sourceforge.net,
	"Dave.Kleikamp" <dave.kleikamp@...cle.com>
Subject: Re: [PATCH 1/1] fs/jfs/jfs_inode.c: atomically set inode->i_flags

On Wed, 2 Apr 2014 13:47:07 -0400
Theodore Ts'o <tytso@....edu> wrote:

> On Wed, Apr 02, 2014 at 07:29:50PM +0200, Fabian Frederick wrote:
> > +	set_mask_bits(&inode->i_flags, S_IMMUTABLE | S_APPEND | S_NOATIME |
> > +				       S_DIRSYNC | S_SYNC, new_fl);
> 
> Warning --- per discussion with Linus over the weekend, he decided he
> really didn't like the set_mask_bits() interface, because it was too
> prone to abuse.  Unfortuantely, Linus had already included an earlier
> version of my patch that used set_mask_bits() in 3.14 without letting
> me know.  This is what I have in my ext4 tree for the merge window,
> which is undergoing final testing at the moment.  This will cause a
> patch conflict, and it's likely (given Linus's dislike of the
> set_mask_bits interface) that set_mask_bits() will end up getting
> removed from the tree, if not when he fixes up the merge conflict, but
> subsequent to -rc1.
> 
> 							- Ted
> 
> 

Thanks a lot Ted, I'll wait your inode patch to got mainline before updating this one.
Of course I don't wanna step on your toes if you prefer releasing patches for all FS :)

Fabian
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/