linux-kernel - Re: [PATCH] integrity: get comm using lock to avoid race in string printing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1396462368.20325.26.camel@dhcp-9-2-203-236.watson.ibm.com>
Date:	Wed, 02 Apr 2014 14:12:48 -0400
From:	Mimi Zohar <zohar@...ux.vnet.ibm.com>
To:	Steve Grubb <sgrubb@...hat.com>
Cc:	Richard Guy Briggs <rgb@...hat.com>, linux-audit@...hat.com,
	linux-kernel@...r.kernel.org,
	linux-security-module@...r.kernel.org, eparis@...hat.com
Subject: Re: [PATCH] integrity: get comm using lock to avoid race in string
 printing

On Wed, 2014-04-02 at 14:00 -0400, Steve Grubb wrote: 
> Hello Mimi,
> 
> On Wednesday, April 02, 2014 01:39:47 PM Mimi Zohar wrote:
> > This change is already being upstreamed as commit 73a6b44 "Integrity:
> > Pass commname via get_task_comm()".
> 
> While I was looking at Richard's patch, I noticed a few places where cause and 
> op are logged and the string isn't tied together with a _ or -. These are in 
> ima/ima_appraise.c line 383, and ima/ima_policy.c lines 333, 657, and 683. Are 
> these fixed upstream? Or should a patch be made?

Nothing has changed in terms of 'cause' and 'op'.  I would suggest
making the changes in integrity_audit.c: integrity_audit_msg().

thanks,

Mimi


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/