linux-kernel - [PATCH] usb: musb: turn phy on

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:	Wed,  2 Apr 2014 21:26:27 +0200
From:	Rabin Vincent <rabin@....in>
To:	Felipe Balbi <balbi@...com>
Cc:	Rabin Vincent <rabin@....in>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] usb: musb: turn phy on

30a70b026b4cde4 ("usb: musb: fix obex in g_nokia.ko causing kernel
panic") broke USB gadget support on Pandaboard because it simply deletes
the call to phy_power_on() and the PHY is therefore never turned on.

Fix it by actually turning the phy on.

Cc: stable@...r.kernel.org
Signed-off-by: Rabin Vincent <rabin@....in>
---
 drivers/usb/musb/musb_gadget.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/usb/musb/musb_gadget.c b/drivers/usb/musb/musb_gadget.c
index d4aa779..09d5883 100644
--- a/drivers/usb/musb/musb_gadget.c
+++ b/drivers/usb/musb/musb_gadget.c
@@ -1850,6 +1850,7 @@ static int musb_gadget_start(struct usb_gadget *g,
 	}
 
 	pm_runtime_get_sync(musb->controller);
+	phy_power_on(musb->phy);
 
 	dev_dbg(musb->controller, "registering driver %s\n", driver->function);
 
@@ -1963,6 +1964,7 @@ static int musb_gadget_stop(struct usb_gadget *g,
 	 * that currently misbehaves.
 	 */
 
+	phy_power_off(musb->phy);
 	pm_runtime_put(musb->controller);
 
 	return 0;
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/