lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 3 Apr 2014 01:12:35 +0200 From: Francois Romieu <romieu@...zoreil.com> To: Struan Bartlett <struan.bartlett@...il.com> Cc: Matt Mackall <mpm@...enic.com>, linux-kernel@...r.kernel.org, Andreas Schwab <schwab@...ux-m68k.org>, netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>, Nikolay Aleksandrov <nikolay@...hat.com>, Andy Shevchenko <andy.shevchenko@...il.com>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Jiri Pirko <jiri@...nulli.us>, Joe Perches <joe@...ches.com>, Dan Aloni <alonid@...tram.com> Subject: Re: [PATCH v3] netconsole: Add tty driver Struan Bartlett <struan.bartlett@...il.com> : [...] > --- a/drivers/net/netconsole.c 2014-03-31 04:40:15.000000000 +0100 > +++ b/drivers/net/netconsole.c 2014-04-01 11:58:50.000000000 +0100 > @@ -15,6 +15,7 @@ > * generic card hooks > * works non-modular > * 2003-09-07 rewritten with netpoll api > + * 2014-03-31 tty driver by Struan Bartlett Useless. [...] > +static int netconsole_tty_put_char(struct tty_struct *tty, unsigned char ch) > +{ > + char temp[2] = { ch, 0 }; > + _write_msg(temp, 1); Please add an empty line after declaration. [...] > @@ -802,11 +857,39 @@ static int __init init_netconsole(void) > if (err) > goto undonotifier; > > + netconsole_tty_driver = alloc_tty_driver(1); alloc_tty_driver is said deprecated in include/linux/tty_driver.h http://marc.info/?l=linux-netdev&m=139629339513575 may delay things a bit. If so please be patient. -- Ueimor -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists